Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Win32 loader lock #22

Closed
wants to merge 3 commits into from

Conversation

DeltaNeverUsed
Copy link

timeBeginPeriod gets called before the game fully starts up, so instead of doing the initialization in dllmain, we should be doing it there to avoid the loader lock.

This is to address #21

@NotNite
Copy link
Owner

NotNite commented Nov 10, 2024

I'm not a huge fan of the amount of stuff inside of this PR - seems to be pulling in a lot more than we need. I opted for a (jankier) solution in #23 that hooks the main function and does the initialization there, skipping loader lock in the process.

Best course of action is to probably test both heavily - you're on Linux, right? If so, I could use your help once the CI finishes building on my branch :)

@DeltaNeverUsed
Copy link
Author

DeltaNeverUsed commented Nov 10, 2024

I'm not a huge fan of the amount of stuff inside of this PR

Yeah, sorry about that

you're on Linux, right? If so, I could use your help once the CI finishes building on my branch :)

I am indeed on Linux, and I'd be happy to help

@NotNite
Copy link
Owner

NotNite commented Nov 10, 2024

No need to apologize - it looks like a large chunk of it is just from the library, and proxy-dll is pretty inflexible, so your choices make sense. GitHub Actions built the DLL on both branches by now, so if you could test them with and without .NET installed into the prefix I'd appreciate it.

@DeltaNeverUsed
Copy link
Author

It appears to work fine on linux with and without dotnet installed 👍

@DeltaNeverUsed
Copy link
Author

Everything's worked fine on my end with those new DLLs. When do you think a new release will be ready?

@NotNite
Copy link
Owner

NotNite commented Nov 11, 2024

I'll likely close this PR and merge mine tomorrow morning, then do a release shortly after.

@DeltaNeverUsed
Copy link
Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants